This repository was archived by the owner on Sep 14, 2019. It is now read-only.
creating and preparing/setting up 4 subsystems and their interfaces#3
Merged
lhmcgann merged 4 commits intoDeepBlueRobotics:masterfrom Jan 14, 2018
Merged
creating and preparing/setting up 4 subsystems and their interfaces#3lhmcgann merged 4 commits intoDeepBlueRobotics:masterfrom
lhmcgann merged 4 commits intoDeepBlueRobotics:masterfrom
Conversation
subsystems and interfaces: Lift, Climber, ClimberAssist, IntakeEject added "implements (interface) in each subsystem did not include drivetrain or auto bc other peopl already doing that
put initDefaultCommand method in interfaces added javadocs for initDefaultCommand method in each subsystem declared and initialized subsystems in Robot
Contributor
|
Git treats an empty directory as not being there. So when you delete the files in a package you leave just an empty folder. This is perfectly normal and you should not have to worry about it once things start getting populated with more files. |
Member
|
For some reason, your commit includes .DS_store even though the gitignore ignores that |
actual file and reference in .gitignore
added a README to commands package so doesn't disappear in github
Contributor
Author
|
I'm not quite sure yet what happened with the .DS_Store file, so can someone pull and see if it shows up/creates errors? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just created 4 subsystems (Climber, ClimberAssist, Lift, and IntakeEject) and their respective interfaces, setting them up and preparing them for further development. I ignored Drivetrain and Auto stuff because other people (i.e. David and Kevin) already created them in their respective forker repos. The main reason I'm asking you to briefly review my commits @brettle is because when I forked the repo and got it into eclipse, the project was missing the two packages for commands and subsystems. So, I created them (as they would have been named), but I'm not sure how they first disappeared or if by creating new ones (even with the exact same names) I potentially messed something up. XP Will packages disappear through GitHub if there is nothing in them? Because Kevin did delete the example command and subsystem...